Added test to sort the language list #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Jun 27, 2020
mAAdhaTTah
reviewed
Jun 27, 2020
|
I resolved the conflicts. Regarding aliases: I just reverted my name changes. |
|
I'm such an idiot. Maybe I should also read the suggested changes? Yeah. Let me just change the titles to ABFN, BFN, and EBNF. I think people will know what the abbreviations mean and for those that don't, there's Google. |
mAAdhaTTah
approved these changes
Jun 27, 2020
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new language, there's always the question of where to put it in the language list.
The language list is generally sorted alphabetically, so I added a test which exactly that with some slight modification to the normal ASCII order with the goal to have a sensible language order.
I also changed some title which I felt where too long (e.g. "Augmented Backus–Naur form" -> "ABNF") or to make easier to find (e.g. "Gamemaker Language" -> "GML: Gamemaker Language").
This should also make code review easier because misplaced entries in the language list are quite common.