-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia: String, character, and other improvements #2363
Conversation
I made some other improvements to Julia:
|
Does this need any other work? |
Looks like prism doesn't support multiline comments, either, btw :) #= a comment
over
multiple
lines
=# Technically, multiline comments can nest, like this, but for syntax highlighting I'm sure you can get away without pairing the delimiters if that's hard to support. #=
foo
#=
bar
=#
still a comment
=# |
Thanks for telling me about multiline comments. I have no idea about Julia, so this really helps.
Not work but review. The other maintainers are very busy, so there's no one to review my PRs. To solve this, I review my own stuff after some time passed (usually 2 weeks). Not ideal but like every open source project we also don't have enough hands. Don't worry, it's not been forgotten. I'll merge this in a few days. |
Great, thanks! |
Thanks ❤️ |
Julia strings are now greedy. I also reformatted the file.
This fixes #2360.