Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more detail in HTTP language #2718 #2722

Merged
merged 14 commits into from
Jan 18, 2021
Merged

more detail in HTTP language #2718 #2722

merged 14 commits into from
Jan 18, 2021

Conversation

Jxck
Copy link
Contributor

@Jxck Jxck commented Jan 17, 2021

parse http language more detail.

  • request-line
    • method
    • request-target
    • http-version
  • response-status
    • http-version
    • status-code
    • reason-phrase

fix for #2718

@github-actions
Copy link

github-actions bot commented Jan 17, 2021

JS File Size Changes (gzipped)

A total of 5 files have changed, with a combined diff of -543 B (-8.2%).

file master pull size diff % diff
components/prism-dot.min.js 604 B 0 Bytes -604 B -100.0%
components/prism-fsharp.min.js 1.11 KB 1.1 KB -4 B -0.4%
components/prism-http.min.js 559 B 644 B +85 B +15.2%
plugins/autoloader/prism-autoloader.min.js 2.15 KB 2.15 KB -5 B -0.2%
plugins/show-language/prism-show-language.min.js 2.16 KB 2.15 KB -15 B -0.7%

Generated by 🚫 dangerJS against 1e71a08

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @Jxck!

I have some minor nits but apart from that, it's pretty much good to go.

components/prism-http.js Outdated Show resolved Hide resolved
components/prism-http.js Outdated Show resolved Hide resolved
components/prism-http.js Show resolved Hide resolved
components/prism-http.js Show resolved Hide resolved
components/prism-http.js Show resolved Hide resolved
tests/languages/http/request-line_feature.test Outdated Show resolved Hide resolved
@Jxck
Copy link
Contributor Author

Jxck commented Jan 18, 2021

@RunDevelopment Thanks, if fixed my PR as your review. hope it works.

@RunDevelopment RunDevelopment linked an issue Jan 18, 2021 that may be closed by this pull request
@RunDevelopment RunDevelopment merged commit 6183fd9 into PrismJS:master Jan 18, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @Jxck!

@Jxck Jxck deleted the #2718 branch January 19, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more detail in HTTP language
2 participants