-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for CFScript #2771
Conversation
JS File Size Changes (gzipped)A total of 3 files have changed, with a combined diff of +720 B (+16.3%).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @mjclemente!
A couple of minor things and then this is ready.
Thanks for the fast, thorough, and really helpful review 😀 I believe I've made all requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick response!
One more comment. Also, could you please add the link to https://cfdocs.org/script in a comment at the beginning of the file? This will be helpful to future contributors.
Makes sense! Changes made. Again, thanks for the prompt and thorough handling! |
Thank you for contributing @mjclemente! |
Thank you! 🎉 |
This partially deals with #2035, though does not resolve it entirely.
CFML has independent tag and script based syntaxes. This adds support for script syntax.
Here are some language references: