Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CFScript #2771

Merged
merged 11 commits into from Feb 19, 2021
Merged

Added support for CFScript #2771

merged 11 commits into from Feb 19, 2021

Conversation

@mjclemente
Copy link
Contributor

@mjclemente mjclemente commented Feb 18, 2021

This partially deals with #2035, though does not resolve it entirely.

CFML has independent tag and script based syntaxes. This adds support for script syntax.

Here are some language references:

@github-actions
Copy link

@github-actions github-actions bot commented Feb 18, 2021

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +720 B (+16.3%).

file master pull size diff % diff
components/prism-cfscript.min.js 0 Bytes 699 B +699 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.19 KB 2.19 KB +10 B +0.5%
plugins/show-language/prism-show-language.min.js 2.23 KB 2.24 KB +11 B +0.5%

Generated by 🚫 dangerJS against 7695c65

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Good work @mjclemente!

A couple of minor things and then this is ready.

components/prism-cfscript.js Outdated Show resolved Hide resolved
components/prism-cfscript.js Outdated Show resolved Hide resolved
components/prism-cfscript.js Outdated Show resolved Hide resolved
components/prism-cfscript.js Outdated Show resolved Hide resolved
components/prism-cfscript.js Outdated Show resolved Hide resolved
components/prism-cfscript.js Outdated Show resolved Hide resolved
components/prism-cfscript.js Show resolved Hide resolved
@mjclemente
Copy link
Contributor Author

@mjclemente mjclemente commented Feb 19, 2021

Thanks for the fast, thorough, and really helpful review 😀

I believe I've made all requested changes.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the quick response!

One more comment. Also, could you please add the link to https://cfdocs.org/script in a comment at the beginning of the file? This will be helpful to future contributors.

components.json Outdated Show resolved Hide resolved
@mjclemente
Copy link
Contributor Author

@mjclemente mjclemente commented Feb 19, 2021

Makes sense!

Changes made. Again, thanks for the prompt and thorough handling!

@RunDevelopment RunDevelopment merged commit b0a6ec8 into PrismJS:master Feb 19, 2021
8 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Feb 19, 2021

Thank you for contributing @mjclemente!

@mjclemente
Copy link
Contributor Author

@mjclemente mjclemente commented Feb 19, 2021

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants