ESLint: Use cache #2959
Merged
ESLint: Use cache #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we save + restore the cache in CI? |
|
Nah, I don't want people to suddenly have to commit the ESLint cache as well. Plus, the cache might be outdated or otherwise invalid (the cache assumes that ESLint rules + config are constant) so it's actually good that the CI doesn't use the cache. |
|
They wouldn't have to commit the cache, same way they don't have to commit the npm cache, but if the eslint cache is assuming things about the rules, then yeah, let's leave it. |
mAAdhaTTah
approved these changes
Jun 21, 2021
RunDevelopment
added a commit
to RunDevelopment/prism
that referenced
this pull request
Jun 27, 2021
The ESLint cache file from PrismJS#2959 and the JSDoc config file were added.
RunDevelopment
added a commit
to RunDevelopment/prism
that referenced
this pull request
Jun 27, 2021
The ESLint cache file from PrismJS#2959 and the JSDoc config file were added.
Merged
RunDevelopment
added a commit
that referenced
this pull request
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint has a caching functionality. Might as well use it since linting got slower after #2951.