Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Fixed styles being applies to nested elements #2980

Merged
merged 1 commit into from Jul 3, 2021

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jul 2, 2021

This fixes #2974.

The problem was that Toolbar's styles didn't expect toolbar items to have child elements. This is a problem because #2789 added a child element to Copy-to-Clipboard's <button>. So the styles got applied to both:

image

This fix is pretty simple. I just added a few >s to the selectors and that's it. All styles for items now only get applied to the direct children (typically there's only one) of the div.toolbar-item wrappers.

image

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

No JS Changes

Generated by 🚫 dangerJS against 44d9359

@RunDevelopment RunDevelopment added this to the v1.24.1 milestone Jul 2, 2021
@RunDevelopment RunDevelopment merged commit 748ecdd into PrismJS:master Jul 3, 2021
11 checks passed
@RunDevelopment RunDevelopment deleted the issue2974 branch Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy to clipboard button has double shadow
2 participants