Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the space character for the show-invisibles plugin #876

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

zeitgeist87
Copy link
Collaborator

This patch adds a bit of position magic, so that the invisibles
are displayed on top of the original character. This allows for
the inclusion of the space character.

The result looks like this:

invisibles

This patch adds a bit of position magic, so that the invisibles
are displayed on top of the original character. This allows for
the inclusion of the space character.
@mAAdhaTTah
Copy link
Member

Nice!

@mAAdhaTTah
Copy link
Member

I dig it. I think the saturation could be turned down a bit. Compared to how I have it in my editor, I think they're a bit dark and hard to distinguish from the characters surrounding them. I changed it to this:

.token.space:before {
  color: hsl(24, 20%, 35%);
  content: '\00B7';
}

@mAAdhaTTah
Copy link
Member

Actually, that only looks better on the darker themes (which is what I tend to use). Not sure what the balance is here.

zeitgeist87 added a commit that referenced this pull request Feb 3, 2016
Add support for the space character for the show-invisibles plugin
@zeitgeist87 zeitgeist87 merged commit 9b596d3 into PrismJS:gh-pages Feb 3, 2016
@LeaVerou
Copy link
Member

LeaVerou commented Feb 4, 2016

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants