Properly dispose subscriptions in example (#109)

Profiscience · Sep 29, 2016 · 995816f · 995816f
1 parent c2c4753
commit 995816f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 20 deletions.
diff --git a/example/dist/bundle.js b/example/dist/bundle.js
diff --git a/example/dist/bundle.js.map b/example/dist/bundle.js.map
diff --git a/example/views/bindings.js b/example/views/bindings.js
@@ -6,12 +6,8 @@ ko.components.register('bindings', {
   synchronous: true,
   viewModel: class Bindings {
     constructor(ctx) {
-      this.sub = ctx.hash.subscribe((h) => {
-        $(`#${h}`).velocity('scroll')
-      })
-    }
-    dispose() {
-      this.sub.dispose()
+      const sub = ctx.hash.subscribe((h) => $(`#${h}`).velocity('scroll'))
+      ctx.addBeforeNavigateCallback(() => sub.dispose())
     }
   },
   template: `

diff --git a/example/views/config.js b/example/views/config.js
@@ -6,12 +6,8 @@ ko.components.register('config', {
   synchronous: true,
   viewModel: class Config {
     constructor(ctx) {
-      this.sub = ctx.hash.subscribe((h) => {
-        $(`#${h}`).velocity('scroll')
-      })
-    }
-    dispose() {
-      this.sub.dispose()
+      const sub = ctx.hash.subscribe((h) => $(`#${h}`).velocity('scroll'))
+      ctx.addBeforeNavigateCallback(() => sub.dispose())
     }
   },
   template: `

diff --git a/example/views/ctx.js b/example/views/ctx.js
@@ -5,12 +5,8 @@ ko.components.register('context', {
   synchronous: true,
   viewModel: class Context {
     constructor(ctx) {
-      this.sub = ctx.hash.subscribe((h) => {
-        $(`#${h}`).velocity('scroll')
-      })
-    }
-    dispose() {
-      this.sub.dispose()
+      const sub = ctx.hash.subscribe((h) => $(`#${h}`).velocity('scroll'))
+      ctx.addBeforeNavigateCallback(() => sub.dispose())
     }
   },
   template: `