Elevator #6
Merged
Elevator #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamgreen12
requested review from
Nummun14,
ShmayaR and
Strflightmight09
and removed request for
Nummun14
ShmayaR
requested changes
Sep 2, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Show resolved
Hide resolved
Nummun14
reviewed
Sep 3, 2025
Nummun14
requested changes
Sep 3, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
Nummun14
requested changes
Sep 4, 2025
src/main/java/frc/trigon/robot/constants/OperatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorCommands.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
nahum is mean
|
there are conflicts you need to resolve |
Nummun14
requested changes
Sep 5, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
Strflightmight09
requested changes
Sep 8, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
Nummun14
requested changes
Sep 8, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
Strflightmight09
requested changes
Sep 9, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
noamgreen12
requested review from
Nummun14,
ShmayaR and
Strflightmight09
and removed request for
ShmayaR
ShmayaR
requested changes
Sep 10, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
Strflightmight09
requested changes
Sep 10, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/ElevatorConstants.java
Outdated
Show resolved
Hide resolved
ShmayaR
reviewed
Sep 10, 2025
src/main/java/frc/trigon/robot/subsystems/elevator/Elevator.java
Outdated
Show resolved
Hide resolved
ShmayaR
previously approved these changes
Sep 10, 2025
Nummun14
previously approved these changes
Sep 10, 2025
Strflightmight09
approved these changes
Sep 10, 2025
ShmayaR
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.