Skip to content

Conversation

karlrado
Copy link

This control allows a user to set the missing tile color to any color they want.

The current default missing tile color is a dark gray, which makes it hard to see, which is fairly acceptable during normal operation since it makes missing tiles less noticable. But if one is tuning the maxwait setting, they might want to see more easily any missing tiles. This can help them distinguish between actual missing tiles and "popping" caused by differences in textures between ZLs.

This control allows a user to set the missing tile color to any
color they want.

The current default missing tile color is a dark gray, which makes it
hard to see, which is fairly acceptable during normal operation
since it makes missing tiles less noticable.  But if one is tuning the
maxwait setting, they might want to see more easily any missing tiles.
This can help them distinguish between actual missing tiles and
"popping" caused by differences in textures between ZLs.
Copy link
Owner

@ProgrammingDinosaur ProgrammingDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's a good NTH.

Thanks for the contribution.

With the approve you can merge the change if you wish, I won't merge it right now in case you want to add something :)

@karlrado
Copy link
Author

@ProgrammingDinosaur I don't see a green (or any color) button to do the merge, as I don't think I have sufficient permissions in this repo to do so. It is also typical for the repo owner to perform PR merges. So please go ahead and merge.

I don't need to add anything else,

@ProgrammingDinosaur
Copy link
Owner

My bad! I thought with the approve you could merge. Merging it now

@ProgrammingDinosaur ProgrammingDinosaur merged commit 4cbd274 into ProgrammingDinosaur:develop Sep 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants