-
Notifications
You must be signed in to change notification settings - Fork 1.3k
886 add MetricsSaver handler to save metrics and details into files #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
66d59b5
Merge pull request #10 from Project-MONAI/master
Nic-Ma 8e19d91
Merge pull request #14 from Project-MONAI/master
Nic-Ma 8f110a0
[DLMED] add IterationHandler refer to the EpochHandler in ignite
Nic-Ma 560802d
[MONAI] python code formatting
monai-bot b2c317e
[DLMED] fix flake8 issue
Nic-Ma 6f2371e
[DLMED] fix the multi-gpu issue
Nic-Ma 7aaa14e
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 4b13a4e
[DLMED] fix typo
Nic-Ma af9fdc6
[DLMED] fix distributed tests
Nic-Ma f586b08
[DLMED] fix flake8 issue
Nic-Ma 8cea632
Merge pull request #16 from Project-MONAI/master
Nic-Ma 8504839
[DLMED] add engine to metrics
Nic-Ma 16b1210
[DLMED] share metric details in engine
Nic-Ma 8036dc0
[DLMED] add metrics report
Nic-Ma f87c46c
[DLMED] add average value to report
Nic-Ma f247d69
[DLMED] add summary report
Nic-Ma 423f724
[DLMED] add docs
Nic-Ma ae89aa3
[MONAI] python code formatting
monai-bot 35bf113
[DLMED] fix flake8 issue
Nic-Ma 432177e
[MONAI] python code formatting
monai-bot be5972a
[DLMED] add unit tests and distributed tests
Nic-Ma 1155a8f
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 982aa5a
[MONAI] python code formatting
monai-bot 8cbbbc4
[DLMED] fix flake8 issue
Nic-Ma 46a0abf
[DLMED] fix typo
Nic-Ma 645fcc1
[DLMED] remove from min_tests
Nic-Ma 3ab555f
[DLMED] remove useless var
Nic-Ma cacf63a
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 3ba905d
[DLMED] add skip flag
Nic-Ma 984bcd8
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 1156dc5
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 17df30e
[DLMED] update according to comments
Nic-Ma cd5b0ed
[DLMED] add dist tests
Nic-Ma 25b05dd
[MONAI] python code formatting
monai-bot cc5936c
[DLMED] fix flake8 issue
Nic-Ma 6b32ce8
[DLMED] enhance some unit tests
Nic-Ma d6f1a7d
[MONAI] python code formatting
monai-bot 6d3b08b
[DLMED] remove from min_tests
Nic-Ma 1bbf865
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 45e5e0a
[DLMED] change to standlone APIs to write files
Nic-Ma 1dde629
[MONAI] python code formatting
monai-bot af77ebb
[DLMED] add file type check
Nic-Ma f23bb4d
[DLMED] add output_type arg
Nic-Ma d53efff
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 7c02550
Merge branch 'master' into 886-add-metrics-report
Nic-Ma 13954c9
[DLMED] develop standlone API
Nic-Ma abcb98a
[MONAI] python code formatting
monai-bot fc274ba
[DLMED] fix flake8 issue
Nic-Ma 5b08da1
Merge branch 'master' into 886-add-metrics-report
Nic-Ma bb03f19
[DLMED] fix flake8 error
Nic-Ma 040470d
[DLMED] fix min test
Nic-Ma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,137 @@ | ||
# Copyright 2020 - 2021 MONAI Consortium | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from typing import TYPE_CHECKING, Callable, List, Optional, Sequence, Union | ||
|
||
from monai.handlers.utils import write_metrics_reports | ||
from monai.utils import ensure_tuple, exact_version, optional_import | ||
from monai.utils.module import get_torch_version_tuple | ||
|
||
Events, _ = optional_import("ignite.engine", "0.4.2", exact_version, "Events") | ||
idist, _ = optional_import("ignite", "0.4.2", exact_version, "distributed") | ||
if TYPE_CHECKING: | ||
from ignite.engine import Engine | ||
else: | ||
Engine, _ = optional_import("ignite.engine", "0.4.2", exact_version, "Engine") | ||
|
||
|
||
class MetricsSaver: | ||
""" | ||
ignite handler to save metrics values and details into expected files. | ||
|
||
Args: | ||
save_dir: directory to save the metrics and metric details. | ||
metrics: expected final metrics to save into files, can be: None, "*" or list of strings. | ||
None - don't save any metrics into files. | ||
"*" - save all the existing metrics in `engine.state.metrics` dict into separate files. | ||
list of strings - specify the expected metrics to save. | ||
default to "*" to save all the metrics into `metrics.csv`. | ||
metric_details: expected metric details to save into files, for example: mean dice | ||
of every channel of every image in the validation dataset. | ||
the data in `engine.state.metric_details` must contain at least 2 dims: (batch, classes, ...), | ||
if not, will unsequeeze to 2 dims. | ||
this arg can be: None, "*" or list of strings. | ||
None - don't save any metrics into files. | ||
"*" - save all the existing metrics in `engine.state.metric_details` dict into separate files. | ||
list of strings - specify the expected metrics to save. | ||
if not None, every metric will save a separate `{metric name}_raw.csv` file. | ||
batch_transform: callable function to extract the meta_dict from input batch data if saving metric details. | ||
used to extract filenames from input dict data. | ||
summary_ops: expected computation operations to generate the summary report. | ||
it can be: None, "*" or list of strings. | ||
None - don't generate summary report for every expected metric_details | ||
"*" - generate summary report for every metric_details with all the supported operations. | ||
list of strings - generate summary report for every metric_details with specified operations, they | ||
should be within this list: [`mean`, `median`, `max`, `min`, `90percent`, `std`]. | ||
default to None. | ||
save_rank: only the handler on specified rank will save to files in multi-gpus validation, default to 0. | ||
delimiter: the delimiter charactor in CSV file, default to "\t". | ||
output_type: expected output file type, supported types: ["csv"], default to "csv". | ||
|
||
""" | ||
|
||
def __init__( | ||
self, | ||
save_dir: str, | ||
metrics: Optional[Union[str, Sequence[str]]] = "*", | ||
metric_details: Optional[Union[str, Sequence[str]]] = None, | ||
batch_transform: Callable = lambda x: x, | ||
summary_ops: Optional[Union[str, Sequence[str]]] = None, | ||
save_rank: int = 0, | ||
delimiter: str = "\t", | ||
output_type: str = "csv", | ||
) -> None: | ||
self.save_dir = save_dir | ||
self.metrics = ensure_tuple(metrics) if metrics is not None else None | ||
self.metric_details = ensure_tuple(metric_details) if metric_details is not None else None | ||
self.batch_transform = batch_transform | ||
self.summary_ops = ensure_tuple(summary_ops) if summary_ops is not None else None | ||
self.save_rank = save_rank | ||
self.deli = delimiter | ||
self.output_type = output_type | ||
self._filenames: List[str] = [] | ||
|
||
def attach(self, engine: Engine) -> None: | ||
""" | ||
Args: | ||
engine: Ignite Engine, it can be a trainer, validator or evaluator. | ||
""" | ||
engine.add_event_handler(Events.STARTED, self._started) | ||
engine.add_event_handler(Events.ITERATION_COMPLETED, self._get_filenames) | ||
engine.add_event_handler(Events.EPOCH_COMPLETED, self) | ||
|
||
def _started(self, engine: Engine) -> None: | ||
self._filenames = [] | ||
|
||
def _get_filenames(self, engine: Engine) -> None: | ||
if self.metric_details is not None: | ||
_filenames = list(ensure_tuple(self.batch_transform(engine.state.batch)["filename_or_obj"])) | ||
self._filenames += _filenames | ||
|
||
def __call__(self, engine: Engine) -> None: | ||
""" | ||
Args: | ||
engine: Ignite Engine, it can be a trainer, validator or evaluator. | ||
""" | ||
ws = idist.get_world_size() | ||
if self.save_rank >= ws: | ||
raise ValueError("target rank is greater than the distributed group size.") | ||
|
||
_images = self._filenames | ||
if ws > 1: | ||
_filenames = self.deli.join(_images) | ||
if get_torch_version_tuple() > (1, 6, 0): | ||
# all gather across all processes | ||
_filenames = self.deli.join(idist.all_gather(_filenames)) | ||
else: | ||
raise RuntimeError("MetricsSaver can not save metric details in distributed mode with PyTorch < 1.7.0.") | ||
_images = _filenames.split(self.deli) | ||
|
||
# only save metrics to file in specified rank | ||
if idist.get_rank() == self.save_rank: | ||
_metrics = {} | ||
if self.metrics is not None and len(engine.state.metrics) > 0: | ||
_metrics = {k: v for k, v in engine.state.metrics.items() if k in self.metrics or "*" in self.metrics} | ||
_metric_details = {} | ||
if self.metric_details is not None and len(engine.state.metric_details) > 0: | ||
for k, v in engine.state.metric_details.items(): | ||
Nic-Ma marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if k in self.metric_details or "*" in self.metric_details: | ||
_metric_details[k] = v | ||
|
||
write_metrics_reports( | ||
save_dir=self.save_dir, | ||
images=_images, | ||
metrics=_metrics, | ||
metric_details=_metric_details, | ||
summary_ops=self.summary_ops, | ||
deli=self.deli, | ||
output_type=self.output_type, | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.