Skip to content

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Nov 3, 2021

Fixes #3240 .

Description

This PR added support to plot images with TensorBoardX, and added support to plot RGB color image.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 3, 2021

Test result for 3D RGB image:

2021-11-03.7.50.28.mov

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 3240 Support to plot 3D and RGB color image 3240 Support to plot 3D and RGB color image Nov 3, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review November 3, 2021 12:33
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 3, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 3, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 3240-support-color-plot branch 2 times, most recently from 65ea80a to ffc11a4 Compare November 3, 2021 14:05
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 3, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 3, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

/build

2 similar comments
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

I tried to verify the TensorBoard plot of image, label and output in tutorial:
https://github.com/Project-MONAI/tutorials/blob/master/3d_segmentation/unet_segmentation_3d_ignite.ipynb
Everything seems OK.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 5, 2021 23:45
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 6, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 6, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 6, 2021

/build

@wyli
Copy link
Contributor

wyli commented Nov 6, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 6, 2021

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Nov 7, 2021

/build

2 similar comments
@wyli
Copy link
Contributor

wyli commented Nov 7, 2021

/build

@wyli
Copy link
Contributor

wyli commented Nov 7, 2021

/build

@wyli wyli disabled auto-merge November 7, 2021 11:01
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 8, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 8, 2021

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 8, 2021 11:32
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 8, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 8, 2021

/build

@Nic-Ma Nic-Ma mentioned this pull request Nov 8, 2021
6 tasks
@wyli
Copy link
Contributor

wyli commented Nov 8, 2021

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Nov 8, 2021

/build

@Nic-Ma Nic-Ma merged commit c8e1184 into Project-MONAI:dev Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_2d_or_3d_image with colour
2 participants