Skip to content

3539 Remove decollate warning #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 24, 2021
Merged

3539 Remove decollate warning #3545

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42a45e0
Merge pull request #19 from Project-MONAI/master
Nic-Ma Feb 1, 2021
cd16a13
Merge pull request #32 from Project-MONAI/master
Nic-Ma Feb 24, 2021
6f87afd
Merge pull request #180 from Project-MONAI/dev
Nic-Ma Jul 22, 2021
f398298
Merge pull request #214 from Project-MONAI/dev
Nic-Ma Sep 8, 2021
a6d5127
Merge pull request #333 from Project-MONAI/dev
Nic-Ma Dec 23, 2021
33ad5eb
[DLMED] remove warning
Nic-Ma Dec 23, 2021
5dd90b3
Merge branch 'dev' into 3539-remove-decollate-warning
Nic-Ma Dec 23, 2021
33d868c
[DLMED] fix typo
Nic-Ma Dec 23, 2021
f065606
Merge branch 'dev' into 3539-remove-decollate-warning
wyli Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions monai/engines/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

from monai.config import IgniteInfo
from monai.engines.utils import IterationEvents, default_metric_cmp_fn, default_prepare_batch
from monai.transforms import Decollated, Transform
from monai.transforms import Decollated
from monai.utils import ensure_tuple, is_scalar, min_version, optional_import

from .utils import engine_apply_transform
Expand Down Expand Up @@ -186,8 +186,8 @@ def set_sampler_epoch(engine: Engine):
self._register_decollate()

if postprocessing is not None:
if not decollate and isinstance(postprocessing, Transform):
warnings.warn("MONAI transforms expect `channel-first` data, `decollate=False` may not work here.")
# tips: if `decollate=False` and `postprocessing` is MONAI transforms, it may not work well
# because all the MONAI transforms expect `channel-first` data
self._register_postprocessing(postprocessing)
if key_metric is not None:
self._register_metrics(key_metric, additional_metrics)
Expand Down