Skip to content

DOC: Use upstream/downstream instead of source/destination #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2022
Merged

DOC: Use upstream/downstream instead of source/destination #316

merged 2 commits into from
Aug 1, 2022

Conversation

Leengit
Copy link
Contributor

@Leengit Leengit commented Jul 26, 2022

For monai.deploy.core.Operator, instead of sometimes using upstream and downstream and sometimes using source and destination, consistently use the former.

@Leengit
DOC: Use upstream/downstream instead of source/destination
998065d 
For monai.deploy.core.Operator, instead of sometimes using "upstream"
and "downstream" and sometimes using "source" and "destination",
consistently use former.

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>
@Leengit Leengit force-pushed the upstream_downstream branch from b0f1399 to 998065d Compare July 26, 2022 13:38
@MMelQin
Copy link
Collaborator

MMelQin commented Jul 28, 2022 •
edited
Loading

@Leengit Thank you very much for the pull request.

The use of source and destination is consistent in the App SDK core, while the example apps, which are not included in the monia-deploy-app-sdk PyPi package, use upstream and downstream.

I believe source and destination are more precise, especially considering when using the add_flow function to connect two operators, a source is connected to a destination. So, I'd say that upstream and downstream in the example apps be changed to source and destination respectively.

@Leengit
DOC: Use source/destination instead of upstream/downstream
e1a0542 
For monai.deploy.core.Operator, instead of sometimes using "upstream"
and "downstream" and sometimes using "source" and "destination",
consistently use the latter.

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Leengit
Copy link
Contributor Author

Leengit commented Aug 1, 2022

@MMelQin I have done as you suggested with this latest commit.

MMelQin
MMelQin approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes to have consistent use of naming.

@MMelQin
Copy link
Collaborator

MMelQin commented Aug 1, 2022

The build failure is caused by the style checking tool flake8 itself, which was working fine.
ModuleNotFoundError: No module named 'flake8.plugins.manager'

The issue with the tool itself will be looked at, and the PR itself can be merged.

@MMelQin MMelQin merged commit 2526579 into Project-MONAI:main Aug 1, 2022
@Leengit Leengit deleted the upstream_downstream branch September 12, 2022 13:07
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
@Leengit @SimoneBendazzoli93
DOC: Use upstream/downstream instead of source/destination (Project-M…
c63af95 
…ONAI#316)

* DOC: Use upstream/downstream instead of source/destination

For monai.deploy.core.Operator, instead of sometimes using "upstream"
and "downstream" and sometimes using "source" and "destination",
consistently use former.

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>

* DOC: Use source/destination instead of upstream/downstream

For monai.deploy.core.Operator, instead of sometimes using "upstream"
and "downstream" and sometimes using "source" and "destination",
consistently use the latter.

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>
Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
@Leengit @SimoneBendazzoli93
DOC: Use upstream/downstream instead of source/destination (Project-M…
fc81010 
…ONAI#316)

* DOC: Use upstream/downstream instead of source/destination

For monai.deploy.core.Operator, instead of sometimes using "upstream"
and "downstream" and sometimes using "source" and "destination",
consistently use former.

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>

* DOC: Use source/destination instead of upstream/downstream

For monai.deploy.core.Operator, instead of sometimes using "upstream"
and "downstream" and sometimes using "source" and "destination",
consistently use the latter.

Signed-off-by: Lee Newberg <lee.newberg@kitware.com>
Signed-off-by: Simone Bendazzoli <simben@kth.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMelQin MMelQin MMelQin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leengit @MMelQin