Enhanced multi-value DataElement parsing #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <mingmelvinq@nvidia.com>
|
Kudos, SonarCloud Quality Gate passed!
|
vikashg
approved these changes
Oct 16, 2022
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the code to treat multi-value DataElement retrieved from SOP instance Dataset differently from single valued ones.
DataElement retrieved from the underlying SOP instance Dataset may be multiple-valued; the retrieval is only needed when the to-be-matched attribute is not in the defined set of study and series attributes and when instance level attributes are used. The existing implementation favors multiple-valued and converts the string representation of the multi-valued into a list, however this also makes a single value into a list which then causes issue when valuating the condition.
Signed-off-by: M Q mingmelvinq@nvidia.com