Release/0.4.0 #458

mocsharp · 2023-08-25T18:53:25Z

Release 0.4.0

Unable to start mig via the cli using the setup documentation #435 Fix CLI to read log dir path from NLog config file.
Enable custom URLs for DICOMWeb STOW-RS API #425 New Virtual Application Entity support for DICOMWeb STOW-RS APIs to enable dynamic endpoints.
Workflow Request Message change request #421 Integrate updated Workflow Request data structure to support multiple sources.
New data plug-ins feature to manipulate incoming and outgoing data.

…ervice (#426) * gh-418 Implement data input plug-in engine and integration with SCP service - Implement IInputDataPluginEngine and IInputDataPlugin - Add unit tests - Update SCP feature in integration test * gh-418 Update CLI to support --plugins and update API doc * gh-418 Rename BackgroundProcessingAsync Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update Ardalis.GuardClauses * Update coverlet.collector * Update Docker.DotNet * Update FluentAssertions * Update xunit * Update NLog * Update MongoDB * Update Polly * Update Monai.Deploy libraries * Update Microsoft .NET 6 libraries * Update fo-dicom * Update Github Action dependencies * Update dependencies versions * Remove fo-dicom logging support and use .NET logging Signed-off-by: Victor Chang <vicchang@nvidia.com>

…DICOMWeb export services (#428) * Update Ardalis.GuardClauses * Update coverlet.collector * Update Docker.DotNet * Update xunit * Update NLog * Update MongoDB * Update Polly * Update Monai.Deploy libraries * Update Microsoft .NET 6 libraries * Update fo-dicom * Remove fo-dicom logging support and use .NET logging * Implement OutputDataPluginEngine for export service (SCU, DICOMWeb) * Add WorkflowInstanceId and TaskId properties for plugins to use * Fix package hash * Fix JSON property name of TaskId * Update Moq, NLog, NLog.Web.AspNetCore and dependencie decisions * Update dependency decisions: Devlooped.SponsorLink * Fix comments Signed-off-by: Victor Chang <vicchang@nvidia.com>

* gh-435 Fix CLI to read log dir path from NLog config file * Update changelog * Add/update unit tests Signed-off-by: Victor Chang <vicchang@nvidia.com>

* gh-434 New APIs to get a list of input/output data plug-ins New PluginAttribute to provide names for the plug-ins * gh-434 Update documentation * gh-434 Update documentation * gh-434 Update CLI with aet plugins and dst plugins commands * Add AttributeUsage to PluginNameAttribute * Update user guide * Fix typo in setup guide * Add unit test for Plug-ins client Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Change the return type of IInputDataPluginEngine to Tuple * Add VirtualApplicationEntity to support dynamic DICOMWeb STOW-RS endpoints * New APIs for Virtual AE and support dynamic endpoints for STOW-RS * Update DICOMWeb STOW-RS integration test feature with VAE support * Update changelog * Update user guide and comments * Remove unused references * Add .trivyignore Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Neil South <neil.south@answerdigital.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Neil South <neil.south@answerdigital.com>

- New APIs to allow plug-in projects to extend database setups and configurations - Add integration test feature for end-to-end RemoteAppExecution - Rename Plugin to PlugIn Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Signed-off-by: Neil South <neil.south@answerdigital.com>

Nds/#422

…ppExecution.dll across Signed-off-by: Neil South <neil.south@answerdigital.com>

Signed-off-by: Neil South <neil.south@answerdigital.com>

Include Plug-ins in Build

* Support new Workflow Request event data structure. * Re-generate EF migration code * Update user guide and changelog * Update ObjectUploadService to call Upload once since it's already handled with Polly. --------- Signed-off-by: Victor Chang <vicchang@nvidia.com>

dbericat

LGTM

Signed-off-by: Victor Chang <vicchang@nvidia.com>

codecov · 2023-08-30T18:15:53Z

Codecov Report

Merging #458 (c91f3b7) into main (b44839a) will increase coverage by 0.38761%.
Report is 22 commits behind head on main.
The diff coverage is 68.76791%.

@@                 Coverage Diff                 @@
##                main        #458         +/-   ##
===================================================
+ Coverage   79.69676%   80.08437%   +0.38761%     
===================================================
  Files            328         379         +51     
  Lines          20578       23941       +3363     
  Branches         950        1081        +131     
===================================================
+ Hits           16400       19173       +2773     
- Misses          3857        4398        +541     
- Partials         321         370         +49

Flag	Coverage Δ
unittests	`80.08437% <68.76791%> (+0.38761%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/CLI/Logging/ConsoleLoggerFactoryExtensions.cs	`0.00000% <0.00000%> (ø)`
src/CLI/Program.cs	`35.84906% <0.00000%> (-1.40584%)`	⬇️
src/CLI/Services/ConfirmationPrompt.cs	`0.00000% <0.00000%> (ø)`
src/CLI/Services/EmbeddedResource.cs	`0.00000% <0.00000%> (ø)`
src/Configuration/ScuConfiguration.cs	`100.00000% <ø> (ø)`
src/Database/DatabaseMigrationManager.cs	`0.00000% <0.00000%> (ø)`
...ork/Configuration/InferenceRequestConfiguration.cs	`100.00000% <ø> (ø)`
...tyFramework/Migrations/20230327190827_R3_0.3.15.cs	`0.00000% <ø> (ø)`
...ork/Migrations/20230824185313_R4_0.4.0.Designer.cs	`0.00000% <0.00000%> (ø)`
...ityFramework/Migrations/20230824185313_R4_0.4.0.cs	`0.00000% <0.00000%> (ø)`
... and 175 more

... and 28 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44839a...c91f3b7. Read the comment docs.

github-actions · 2023-09-01T23:28:29Z

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

GitHub Release

Signed-off-by: Victor Chang <vicchang@nvidia.com> Related Work Items: #118, #120, #121, #122, #123, #126, #130, #131, #132, #133, #135, #136, #139, #140, #142, #143, #144, #145, #146, #147, #148, #150, #151, #152, #156, #157, #158, #164, #166, #167, #169, #170, #177, #182, #185, #186, #187, #189, #190, #194, #196, #197, #198, #201, #203, #204, #207, #210, #211, #212, #213, #215, #217, #222, #223, #281, #293, #309, #313, #314, #319, #323, #326, #327, #328, #330, #332, #333, #334, #335, #336, #337, #338, #342, #343, #344, #345, #346, #348, #350, #352, #354, #355, #366, #371, #372, #378, #379, #386, #448, #455, #458, #464, #477

mocsharp and others added 30 commits August 3, 2023 09:14

Input/output data plug-in engine (#423)

85d7d94

Signed-off-by: Victor Chang <vicchang@nvidia.com>

gh-435 Fix CLI to read log dir path from NLog config file (#436)

0ff1963

* gh-435 Fix CLI to read log dir path from NLog config file * Update changelog * Add/update unit tests Signed-off-by: Victor Chang <vicchang@nvidia.com>

Update Ardalis.GuardClauses

b780769

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Update coverlet.collector

d945237

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Update Microsoft .NET 6 libraries

adef5cf

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Update fo-dicom

e5f94a0

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Implement OutputDataPluginEngine for export service (SCU, DICOMWeb)

9023a65

Signed-off-by: Victor Chang <vicchang@nvidia.com>

adding externalApp plugins

cf9976f

Signed-off-by: Neil South <neil.south@answerdigital.com>

Update licenses

14da905

Include WorkflowInstanceId and TaskId in Payload

4c7499b

Signed-off-by: Victor Chang <vicchang@nvidia.com>

fixing up errors

d701f62

Signed-off-by: Neil South <neil.south@answerdigital.com>

adding tag list to configuration

4aff9cf

Signed-off-by: Neil South <neil.south@answerdigital.com>

fix up samll issues

932d718

Signed-off-by: Neil South <neil.south@answerdigital.com>

change to how dicomTag are stored

64feb58

Signed-off-by: Neil South <neil.south@answerdigital.com>

refactoring and more tests

3d6015c

Signed-off-by: Neil South <neil.south@answerdigital.com>

adding test

bbced00

Signed-off-by: Neil South <neil.south@answerdigital.com>

Regenerate EF DB migration code

fa9dbeb

Fix unit test

22c23d2

Signed-off-by: Neil South <neil.south@answerdigital.com>

Refactor RemoteAppExecution plug-ins to a new project

0729d34

- New APIs to allow plug-in projects to extend database setups and configurations - Add integration test feature for end-to-end RemoteAppExecution - Rename Plugin to PlugIn Signed-off-by: Victor Chang <vicchang@nvidia.com>

Ignore generated code from license scanning

adc1098

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Include WorkflowInstanceId and TaskId in the md.workflow.request event

244c6f3

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Rename plug-ins

46c5840

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Update user guide with data plug-ins feature

27e4a3c

Signed-off-by: Victor Chang <vicchang@nvidia.com>

fix up export complete message for external app execution

9ab118b

Signed-off-by: Neil South <neil.south@answerdigital.com>

Merge pull request #429 from Project-MONAI/nds/#422

2eacbce

Nds/#422

neildsouth and others added 4 commits August 25, 2023 14:55

change so that publish and build copy the new plugin assembly RemoteA…

f88af26

…ppExecution.dll across Signed-off-by: Neil South <neil.south@answerdigital.com>

fixup for docker build

b069e17

Signed-off-by: Neil South <neil.south@answerdigital.com>

Merge pull request #456 from Project-MONAI/nds-fix-IOPlugin-copy

d619c62

Include Plug-ins in Build

mocsharp added the build Build & build workflow label Aug 25, 2023

mocsharp added this to the 0.4.0 milestone Aug 25, 2023

mocsharp self-assigned this Aug 25, 2023

dbericat self-requested a review August 25, 2023 20:53

dbericat approved these changes Aug 25, 2023

View reviewed changes

Handle exception thrown from plug-in engine

a281db0

Signed-off-by: Victor Chang <vicchang@nvidia.com>

Copyedit doc changes for the 0.4.0 release (#464)

c91f3b7

mocsharp merged commit 0ba5ba5 into main Sep 1, 2023
29 of 31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/0.4.0 #458

Release/0.4.0 #458

mocsharp commented Aug 25, 2023

dbericat left a comment

codecov bot commented Aug 30, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023

Release/0.4.0 #458

Release/0.4.0 #458

Conversation

mocsharp commented Aug 25, 2023

dbericat left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 30, 2023 • edited Loading

Codecov Report

github-actions bot commented Sep 1, 2023

codecov bot commented Aug 30, 2023 •

edited

Loading