Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 24, 2022

Description

A new configuration key createBuckets that allows users to specify a list of buckets (comma separated) to create on startup.

e.g

...
"createBuckets": "my-bucket-1, my-bucket-2, your-bucket-3"
...

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the enhancement New feature or request label Oct 24, 2022
@mocsharp mocsharp added this to the 0.2.8 milestone Oct 24, 2022
@mocsharp mocsharp self-assigned this Oct 24, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #100 (300cf23) into develop (91e42e7) will increase coverage by 4.05304%.
The diff coverage is 65.86826%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #100         +/-   ##
===================================================
+ Coverage   47.96574%   52.01878%   +4.05304%     
===================================================
  Files             25          27          +2     
  Lines            934        1065        +131     
  Branches          56          66         +10     
===================================================
+ Hits             448         554        +106     
- Misses           477         499         +22     
- Partials           9          12          +3     
Flag Coverage Δ
unittests 52.01878% <65.86826%> (+4.05304%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Plugins/MinIO/MinIoClientFactory.cs 0.00000% <0.00000%> (ø)
src/Plugins/MinIO/MinIoStorageService.cs 0.00000% <0.00000%> (ø)
src/Plugins/MinIO/MinIoStartup.cs 88.88889% <88.88889%> (ø)
src/Plugins/MinIO/ConfigurationKeys.cs 100.00000% <100.00000%> (ø)
src/Plugins/MinIO/MinIoHealthCheck.cs 80.00000% <100.00000%> (ø)
src/Plugins/MinIO/ServiceRegistration.cs 100.00000% <100.00000%> (ø)
src/Plugins/MinIO/Tests/MinIoHealthCheckTest.cs 100.00000% <100.00000%> (ø)
src/Plugins/MinIO/Tests/MinIoStartupTest.cs 100.00000% <100.00000%> (ø)
src/Plugins/MinIO/Tests/ServiceRegistrationTest.cs 100.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e42e7...300cf23. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit b0f74d4 into develop Oct 25, 2022
@mocsharp mocsharp deleted the vchang/ig-221 branch October 25, 2022 15:53
mocsharp added a commit that referenced this pull request Oct 25, 2022
* MinIO: A new hosted service to create buckets on startup

Signed-off-by: Victor Chang <vicchang@nvidia.com>
mocsharp added a commit that referenced this pull request Oct 25, 2022
* Bug fixes (#63)

* Log temporary credential policy for debugging
* Update policy to return distinct paths
* Fix unit test
* Enable concurrent calls to create MinIo clients

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* MinIO: A new hosted service to create buckets on startup (#100)

* MinIO: A new hosted service to create buckets on startup

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Bump actions/cache from 3.0.8 to 3.0.11 (#93)

Bumps [actions/cache](https://github.com/actions/cache) from 3.0.8 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.8...v3.0.11)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump gittools/actions from 0.9.13 to 0.9.14 (#92)

Bumps [gittools/actions](https://github.com/gittools/actions) from 0.9.13 to 0.9.14.
- [Release notes](https://github.com/gittools/actions/releases)
- [Commits](GitTools/actions@v0.9.13...v0.9.14)

---
updated-dependencies:
- dependency-name: gittools/actions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-artifact from 3.1.0 to 3.1.1 (#97)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3.1.0...v3.1.1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-dotnet from 2 to 3 (#86)

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 3.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.8 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants