Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jun 29, 2022

Fixes #18 .

Description

The GetObjectArgs().WithCallbackStream(...) takes Action<Stream> which would not work if a Func<Stream, Task> is pass in. The error only occurs when downloading a large number of files.

We should create an integration test to test each plug-in individually.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Jun 29, 2022
@mocsharp mocsharp added this to the 0.1.1 milestone Jun 29, 2022
@mocsharp mocsharp requested a review from jackschofield23 June 29, 2022 23:16
@mocsharp mocsharp self-assigned this Jun 29, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #19 (eda7afc) into main (9612cb4) will decrease coverage by 0.08706%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #19         +/-   ##
===================================================
- Coverage   32.29730%   32.21024%   -0.08707%     
===================================================
  Files             22          22                 
  Lines            740         742          +2     
  Branches          48          48                 
===================================================
  Hits             239         239                 
- Misses           499         501          +2     
  Partials           2           2                 
Flag Coverage Δ
unittests 32.21024% <0.00000%> (-0.08707%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Plugins/MinIO/MinIoStorageService.cs 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9612cb4...eda7afc. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit ae27bd6 into main Jun 30, 2022
@mocsharp mocsharp deleted the vchang/gh-18 branch June 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[MinIO] GetObjectAsync throws System.ObjectDisposedException
2 participants