Skip to content

Conversation

neildsouth
Copy link
Collaborator

Fixes # .

This fixs the issue with the created user credentials

Status

Ready

Types of changes

  • [ x] Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • [ x] All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #22 (dbad738) into release/0.2.0 (a40e1eb) will decrease coverage by 1.45091%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/0.2.0         #22         +/-   ##
=======================================================
- Coverage       32.21024%   30.75933%   -1.45092%     
=======================================================
  Files                 22          22                 
  Lines                742         777         +35     
  Branches              48          52          +4     
=======================================================
  Hits                 239         239                 
- Misses               501         536         +35     
  Partials               2           2                 
Flag Coverage Δ
unittests 30.75933% <0.00000%> (-1.45092%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Plugins/MinIO/StorageAdminService.cs 0.00000% <0.00000%> (ø)
...c/Plugins/MinIO/Tests/MinioPolicyExtensionsTest.cs 9.09091% <0.00000%> (-90.90910%) ⬇️
src/S3Policy/PolicyExtensions.cs 53.04348% <0.00000%> (-0.46529%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40e1eb...dbad738. Read the comment docs.

@mocsharp mocsharp changed the base branch from release/0.1.0 to release/0.2.0 July 21, 2022 16:03
@neildsouth neildsouth requested a review from mocsharp July 21, 2022 16:28
lillie-dae and others added 8 commits July 21, 2022 09:29
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@mocsharp mocsharp force-pushed the sto-255-admin-module-error branch from e0100e8 to dbad738 Compare July 21, 2022 16:34
@neildsouth neildsouth merged commit 54f7824 into release/0.2.0 Jul 22, 2022
@neildsouth neildsouth deleted the sto-255-admin-module-error branch July 22, 2022 10:09
@mocsharp mocsharp added the bug Something isn't working label Aug 16, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Aug 16, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants