Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jul 21, 2022

Description

  • Ensure that unique paths are used in the policy to prevent exceptions.
  • Expose the RemoveUser method

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested a review from neildsouth July 21, 2022 20:55
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #23 (a22a5dd) into sto-255-admin-module-error (dbad738) will decrease coverage by 0.80946%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                         Coverage Diff                          @@
##           sto-255-admin-module-error         #23         +/-   ##
====================================================================
- Coverage                    30.75933%   29.94987%   -0.80946%     
====================================================================
  Files                              22          22                 
  Lines                             777         798         +21     
  Branches                           52          52                 
====================================================================
  Hits                              239         239                 
- Misses                            536         557         +21     
  Partials                            2           2                 
Flag Coverage Δ
unittests 29.94987% <0.00000%> (-0.80946%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Plugins/MinIO/StorageAdminService.cs 0.00000% <0.00000%> (ø)
src/S3Policy/PolicyExtensions.cs 50.83333% <0.00000%> (-2.21016%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbad738...a22a5dd. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Base automatically changed from sto-255-admin-module-error to release/0.2.0 July 22, 2022 10:09
@mocsharp mocsharp merged commit 6e2935a into release/0.2.0 Jul 22, 2022
@mocsharp mocsharp deleted the vchang/unique-paths branch July 22, 2022 15:05
@mocsharp mocsharp added the bug Something isn't working label Aug 16, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Aug 16, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants