Skip to content

Conversation

neildsouth
Copy link
Collaborator

Signed-off-by: Neil South neil.south@answerdigital.com

Description

Fixes # . the fact that the AllowAllS3ActionsInUserFolder policy needs forward slash's

Status

Ready

Types of changes

  • [ x] Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • [x ] New tests added to cover the changes.
  • [ x] All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #24 (2dff666) into release/0.2.0 (6e2935a) will increase coverage by 7.98545%.
The diff coverage is 85.71429%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/0.2.0         #24         +/-   ##
=======================================================
+ Coverage       29.94987%   37.93532%   +7.98544%     
=======================================================
  Files                 22          22                 
  Lines                798         804          +6     
  Branches              52          53          +1     
=======================================================
+ Hits                 239         305         +66     
+ Misses               557         495         -62     
- Partials               2           4          +2     
Flag Coverage Δ
unittests 37.93532% <85.71429%> (+7.98544%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../S3Policy/Tests/Extensions/PolicyExtensionsTest.cs 97.72727% <83.33333%> (-2.27273%) ⬇️
src/S3Policy/PolicyExtensions.cs 98.33333% <100.00000%> (+47.50000%) ⬆️
src/S3Policy/Policies/PolicyRequest.cs 100.00000% <0.00000%> (+100.00000%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2935a...2dff666. Read the comment docs.

@mocsharp mocsharp merged commit cd1974f into release/0.2.0 Jul 25, 2022
@mocsharp mocsharp deleted the nds-policy-fix branch July 25, 2022 17:54
@mocsharp mocsharp added this to the 0.2.0 milestone Aug 16, 2022
@mocsharp mocsharp added the bug Something isn't working label Aug 16, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants