Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Aug 22, 2022

Description

Fix #41

For Argo to access the minio path in the bucket, the directory (in addition to dir-name/*) must be included in the policy.

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Aug 22, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #40 (fbe2db9) into develop (5d478db) will increase coverage by 0.12438%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #40         +/-   ##
===================================================
+ Coverage   37.93532%   38.05970%   +0.12438%     
===================================================
  Files             22          22                 
  Lines            804         804                 
  Branches          53          52          -1     
===================================================
+ Hits             305         306          +1     
  Misses           495         495                 
+ Partials           4           3          -1     
Flag Coverage Δ
unittests 38.05970% <100.00000%> (+0.12438%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/S3Policy/PolicyExtensions.cs 98.33333% <100.00000%> (ø)
.../S3Policy/Tests/Extensions/PolicyExtensionsTest.cs 100.00000% <100.00000%> (+2.27272%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d478db...fbe2db9. Read the comment docs.

@mocsharp mocsharp merged commit 26e8500 into develop Aug 23, 2022
@mocsharp mocsharp deleted the vchang/fix-policy branch August 23, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Access denied download data from Minio in Argo workflows
3 participants