Skip to content

Fix wrong health check API call #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Fix wrong health check API call #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d099f6
Fix wrong health check API call
mocsharp Sep 23, 2022
f16e376
Update package & license
mocsharp Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/dependency_decisions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- :who: mocsharp
:why: Apache-2.0 (https://github.com/aws/aws-sdk-net/raw/master/License.txt)
:versions:
- 3.7.13.5
- 3.7.13.8
:when: 2022-08-29 18:11:12.923214877 Z
- - :approve
- AWSSDK.S3
Expand Down
4 changes: 2 additions & 2 deletions src/Plugins/MinIO/HealthCheckBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Monai.Deploy.Storage.MinIO
{
public class HealthCheckBuilder : HealthCheckRegistrationBase
{
public override IHealthChecksBuilder ConfigureAdminHealthCheck(IHealthChecksBuilder builder, HealthStatus? failureStatus = null, IEnumerable<string>? tags = null, TimeSpan? timeout = null) =>
public override IHealthChecksBuilder ConfigureHealthCheck(IHealthChecksBuilder builder, HealthStatus? failureStatus = null, IEnumerable<string>? tags = null, TimeSpan? timeout = null) =>
builder.Add(new HealthCheckRegistration(
ConfigurationKeys.StorageServiceName,
serviceProvider =>
Expand All @@ -36,7 +36,7 @@ public override IHealthChecksBuilder ConfigureAdminHealthCheck(IHealthChecksBuil
tags,
timeout));

public override IHealthChecksBuilder ConfigureHealthCheck(IHealthChecksBuilder builder, HealthStatus? failureStatus = null, IEnumerable<string>? tags = null, TimeSpan? timeout = null) =>
public override IHealthChecksBuilder ConfigureAdminHealthCheck(IHealthChecksBuilder builder, HealthStatus? failureStatus = null, IEnumerable<string>? tags = null, TimeSpan? timeout = null) =>
builder.Add(new HealthCheckRegistration(
$"{ConfigurationKeys.StorageServiceName}-admin",
serviceProvider =>
Expand Down
6 changes: 3 additions & 3 deletions third-party-licenses.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ SOFTWARE.


<details>
<summary>AWSSDK.Core 3.7.13.5</summary>
<summary>AWSSDK.Core 3.7.13.8</summary>

## AWSSDK.Core

- Version: 3.7.13.5
- Version: 3.7.13.8
- Authors: Amazon Web Services
- Owners: Amazon Web Services
- Project URL: https://github.com/aws/aws-sdk-net/
- Source: [NuGet](https://www.nuget.org/packages/AWSSDK.Core/3.7.13.5)
- Source: [NuGet](https://www.nuget.org/packages/AWSSDK.Core/3.7.13.8)
- License: [Apache-2.0](https://github.com/aws/aws-sdk-net/raw/master/License.txt)


Expand Down