Skip to content

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Dec 12, 2022

Fixes #.

Description

add training mode descriptions in README
update prepare_patches.py
change to "fast" mode

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

KumoLiu and others added 24 commits July 21, 2022 10:22
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
update prepare_patches

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bhashemian bhashemian self-requested a review December 12, 2022 14:29
Copy link
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KumoLiu, it looks good to me. just few comments of the texts.

Signed-off-by: KumoLiu <yunl@nvidia.com>
@bhashemian
Copy link
Member

@KumoLiu, could you please update the default mode of other hovernet pipelines too? thanks

parser.add_argument("--mode", type=str, default="original", help="choose either `original` or `fast`")

parser.add_argument("--mode", type=str, default="original", help="HoVerNet mode (original/fast)")

Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 13, 2022

@KumoLiu, could you please update the default mode of other hovernet pipelines too? thanks

parser.add_argument("--mode", type=str, default="original", help="choose either `original` or `fast`")

parser.add_argument("--mode", type=str, default="original", help="HoVerNet mode (original/fast)")

Of course, have updated!

@bhashemian
Copy link
Member

@KumoLiu this one needs to be fixed too. Thanks

model.load_state_dict(torch.load(cfg["ckpt"], map_location=device)["net"])

Signed-off-by: KumoLiu <yunl@nvidia.com>
change to fast mode

Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 13, 2022

Hi @drbeh, I have already updated the performance curve, could you please double-check the license descriptions in the README, if that's ok I think this PR can be merged, thanks!

@wyli
Copy link
Contributor

wyli commented Dec 15, 2022

in the readme and notebookt I think we should cite this paper https://www.sciencedirect.com/science/article/abs/pii/S1361841519301045 instead of the arxiv version.

do we need an acknowledgement section for the original author/implementations? the detection folder's readme is a good example https://github.com/Project-MONAI/tutorials/tree/main/detection#acknowledgement cc @drbeh @JHancox

@bhashemian
Copy link
Member

bhashemian commented Dec 15, 2022

in the readme and notebookt I think we should cite this paper https://www.sciencedirect.com/science/article/abs/pii/S1361841519301045 instead of the arxiv version.

do we need an acknowledgement section for the original author/implementations? the detection folder's readme is a good example https://github.com/Project-MONAI/tutorials/tree/main/detection#acknowledgement cc @drbeh @JHancox

I agree with @wyli! although we don't have any external contributor to acknowledge.

@KumoLiu would it be possible to update them using the following citation? thanks

Simon Graham, Quoc Dang Vu, Shan E Ahmed Raza, Ayesha Azam, Yee Wah Tsang, Jin Tae Kwak, Nasir Rajpoot, Hover-Net: Simultaneous segmentation and classification of nuclei in multi-tissue histology images, Medical Image Analysis, 2019
https://doi.org/10.1016/j.media.2019.101563

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli wyli merged commit 499dfdb into Project-MONAI:main Dec 15, 2022
@KumoLiu KumoLiu deleted the update-hovernet-readme branch December 16, 2022 06:26
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes #.

### Description
add training mode descriptions in README
update prepare_patches.py
change to "fast" mode

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants