Skip to content

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Sep 21, 2025

Fixes #2031.

Description

This will change the failing CICD check to use Github CPU runners.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod ericspod requested a review from KumoLiu September 21, 2025 19:22
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod
Copy link
Member Author

Hi @KumoLiu this is the solution I think for getting the tests running again using CPU runners. One issue that we'll find is notebooks will have to run under CPU, some will be very slow as a result plus many in the repo which were tested with GPU cannot be retested now. We can make this change now to put through the PRs we have waiting, or we can change branch rules to allow repo owners to circumvent stuck tests. Thoughts?

@KumoLiu
Copy link
Contributor

KumoLiu commented Sep 22, 2025

We can make this change now to put through the PRs we have waiting, or we can change branch rules to allow repo owners to circumvent stuck tests. Thoughts?

Hi @ericspod, yes. we can merge this one now to put through the PRs we have waiting and also let me change the premerge-notebools as a not "required" check, then if there are some tests must be runned on the GPU, the PR will not stuck as well. What do you think?

@KumoLiu KumoLiu enabled auto-merge (squash) September 22, 2025 03:38
@KumoLiu KumoLiu merged commit b448cf2 into Project-MONAI:main Sep 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

premerge-notebooks Not Running
2 participants