GHG Accounting

[krcolbert]

Hello,

This push request is for updating the Project Drawdown Solutions model for the purpose of developing the greenhouse gas accounting method.

(1) Updated the greenhouse gas accounting method for the CO2 and CH4 modules. This way we can show results in both individual gas units and CO2-equivalent units.
(2) Introduced a module for N2O.
(3) Updated the Global Warming Potential (GWP) conversions in the emission factors.
(4) Included a tutorial for how to use the new features with example solutions Improved Rice and Landfill Methane.

Warm regards,
Kristina Colbert

[denised]

@krcolbert

I was unable to load the improvedrice scenario due to the undefined self.no2 reference I mentioned in the comments. Did it work for you?

Otherwise, I am pretty happy with what I see. The main thing that has not been addressed is testing. There are actually two parts to this: adding some unit tests for the new code (to the models/tests directory) and removing some of the existing tests of the solutions that will now break because the numbers they return are different. The second one I will take care of once we have the scenarios implemented and working. But I would appreciate it if you could create a test case or two for the new functionality --- I hope the existing tests are a reasonable guide, let me know if they aren't.

Other than that, please fix the scenario initialization, and add the initialization for the other affected scenarios.

I put a lot of comments in your wonderful documentation file --- I would like to see this better integrated into the rest of the code, but it is a much lower priority for getting this project accepted.

Thank you!

[krcolbert]

Hi Denise,

Thank you for taking a look over the code and trying to run it. I did also end up having the same error as you about the N2O in the init.py. That was a mistake on my part. It is now corrected and the tutorial script will run for me. I think you have access to the second commit. Not sure how that all works - but let me know if you can't see it and we'll try to get it on here.

In the next commit, I will add the remaining multi-gas solutions. The current commit, only has edits to the improved rice and landfill methane solutions as two test examples. I can also put together a Jupiter Notebook for easier tutorial and test capabilities.

Many thanks for you comments!
Kristina

[denised]

Kristina --- That sounds great --- I look forward to seeing it.

…

-- Denise Draper ***@***.***

On Wed, Aug 18, 2021, at 12:03 PM, Kristina Colbert wrote: Hi Denise, Thank you for taking a look over the code and trying to run it. I did also end up having the same error as you about the N2O in the *init*.py. That was a mistake on my part. It is now corrected and the tutorial script will run for me. I think you have access to the second commit. Not sure how that all works - but let me know if you can't see it and we'll try to get it on here. In the next commit, I will add the remaining multi-gas solutions. The current commit, only has edits to the improved rice and landfill methane solutions as two test examples. I can also put together a Jupiter Notebook for easier tutorial and test capabilities. Many thanks for you comments! Kristina — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#391 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKAMTTPF2KPKBPIQE4WNP3T5P7YPANCNFSM5B4RTAFA>.

[krcolbert]

Hi Denise,

I've got a lot here that's been updated. And I'm pretty sure it will be ready to be merged. Everything is working on my end.

To give you a brief overview, I've added three Jupyter notebooks:
1.) Tutorial_Climate_Modeling
2.) Tutorial_GHG_Accounting
3.) Test_Multigas_Solutions

I also added some functionality to the Start_Here like we talked about doing.

And, there are several init.py files that are changed for the multi-gas solutions. You can test that they are all working with the Jupyter notebook called Test_Multigas_Solutions.

Let me know if you see anything that's not working out.
Kristina

[denised]

@krcolbert This looks great! I'm happy you did the documentation as well. I've asked for signoff from Project Drawdown to accept this change into code base.