Skip to content

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Jan 8, 2021

This PR comments out the Notebook gallery since those aren't real resources we want to display to the public and adds a links.md page containing information from the Content Catalog Google Sheet.

@jukent
Copy link
Contributor Author

jukent commented Jan 8, 2021

@kmpaul @clyne @brian-rose This PR is ready for review. It looks as though I do not have permission to request reviewers.

@brian-rose
Copy link
Member

Looks like the home page is corrupted:
https://projectpythia--20.org.readthedocs.build/en/20/index.html

@jukent
Copy link
Contributor Author

jukent commented Jan 8, 2021

Looks like the home page is corrupted:
https://projectpythia--20.org.readthedocs.build/en/20/index.html

Good catch! I was so focused on checking the appearance of links.html.

I'll fix this now!

Copy link
Contributor

@clyne clyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this, @jukent

@kmpaul @brian-rose just a quick reminder that I'm hoping to have this PR merged in time for AMS this coming week if possible.

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but I wouldn't hold this up for it.

@@ -0,0 +1,23 @@
# Link to External Resources

The members of Project Pythia approve of these resources on Python specific topics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve seems a bit strong. How about "Project Pythia find the links below to be useful resources on a variety of Python topics." ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be better, avoiding appearance of some ill-defined "approval" process.

But otherwise all looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I was uncertain on the best language to use.

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think it's ready to merge.

Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few grammar suggestions...

jukent and others added 2 commits January 11, 2021 10:44
Co-authored-by: Kevin Paul <kpaul@ucar.edu>
Co-authored-by: Kevin Paul <kpaul@ucar.edu>
@jukent jukent requested a review from kmpaul January 11, 2021 17:44
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@kmpaul kmpaul merged commit e27c628 into ProjectPythia:main Jan 11, 2021
@clyne
Copy link
Contributor

clyne commented Jan 11, 2021

Thanks for the quick turnaround, All!

@kmpaul kmpaul mentioned this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants