-
Notifications
You must be signed in to change notification settings - Fork 23
Links #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links #20
Conversation
@kmpaul @clyne @brian-rose This PR is ready for review. It looks as though I do not have permission to request reviewers. |
Looks like the home page is corrupted: |
Good catch! I was so focused on checking the appearance of links.html. I'll fix this now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround on this, @jukent
@kmpaul @brian-rose just a quick reminder that I'm hoping to have this PR merged in time for AMS this coming week if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but I wouldn't hold this up for it.
content/pages/links.md
Outdated
@@ -0,0 +1,23 @@ | |||
# Link to External Resources | |||
|
|||
The members of Project Pythia approve of these resources on Python specific topics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve seems a bit strong. How about "Project Pythia find the links below to be useful resources on a variety of Python topics." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be better, avoiding appearance of some ill-defined "approval" process.
But otherwise all looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I was uncertain on the best language to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I think it's ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few grammar suggestions...
Co-authored-by: Kevin Paul <kpaul@ucar.edu>
Co-authored-by: Kevin Paul <kpaul@ucar.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
Thanks for the quick turnaround, All! |
This PR comments out the Notebook gallery since those aren't real resources we want to display to the public and adds a links.md page containing information from the Content Catalog Google Sheet.