New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marker.txt detection no longer opens an InputStream that's never closed #1195

Merged

Josh-Larson merged 1 commit into ProjectSWGCore:master from madsboddum:marker_txt_leak

Mar 30, 2023

Member

madsboddum commented Mar 30, 2023

I saw two options:

Closing the InputStream that was opened
Not opening an InputStream to begin with

I figured simply creating an URL would also do what we wanted, keeping the code simple.


          marker.txt detection no longer opens an InputStream that's never closed

madsboddum added the BUGFIX label

madsboddum self-assigned this

madsboddum requested a review from Josh-Larson

March 30, 2023 17:47

Josh-Larson merged commit 50620f2 into ProjectSWGCore:master

madsboddum deleted the marker_txt_leak branch

April 2, 2023 17:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUGFIX