Dockerfile overhaul #1357
Merged
Dockerfile overhaul #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Docker image works on any host OS Problem was that jlink produces OS-specific artifacts, so you couldn't make a functional Docker image on Windows. Final Docker image size has also been reduced, roughly from 240MB to 170MB, by using Alpine as the new base image. Support for Debian Stretch ended on the 30th of June 2022.
madsboddum
force-pushed
the
docker-base-image
branch
from
51f7b97
to
60820b3
Compare
…mage, to help ensure it keeps on working
madsboddum
force-pushed
the
docker-base-image
branch
from
60820b3
to
8ca33b7
Compare
madsboddum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1351
In short:
Dependabot
As for automatic updates to the base image using Dependabot, being a multi-stage build now, we appear to have lost the option to have Dependabot submit update PRs: dependabot/dependabot-core#7640
Technically we could work around it by having two Dockerfiles, as described in that issue, but I'm unsure if the added complexity is worth it at this time.
Docker image size
Debian Stretch has been replaced with Alpine 3.
Docker image size difference, Alpine vs. Debian: