Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for displaying effects on affected targets and support … #918

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

madsboddum
Copy link
Member

@madsboddum madsboddum commented Dec 21, 2022

…for the Bacta Shot ability

Relates to #908

On the combat spam packet:
I digged through some packet captures and wasn't able to find any obvious strings for the combat log.
So instead of displaying something obviously incorrect, I decided to just not show anything until we know more.

@madsboddum madsboddum added the FEATURE New feature or request label Dec 22, 2022
@Undercova Undercova modified the milestones: Game Update ? - Medic, Game Update ? - Combat Medic Dec 28, 2022
@madsboddum
Copy link
Member Author

@Josh-Larson I have just resolved the merge conflict in combat_commands.sdb

@Josh-Larson Josh-Larson merged commit 87ffd9b into ProjectSWGCore:master Dec 29, 2022
@Undercova
Copy link
Member

right now it is possible to "spam" the bacta shot command :)
first time it works fine (button) ... then it starts to blink and looks like it is unavailable but you are able to fire it off anyway

image

@madsboddum
Copy link
Member Author

right now it is possible to "spam" the bacta shot command :) first time it works fine (button) ... then it starts to blink and looks like it is unavailable but you are able to fire it off anyway

image

Strange, I can't spam it. It's simply queued as the next available ability and displays a cooldown.

@Undercova Undercova linked an issue Dec 30, 2022 that may be closed by this pull request
@madsboddum madsboddum deleted the bacta_shot branch April 2, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Medic] Bacta Shot (basic / improved / advanced)
3 participants