-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the voting contract #53
added the voting contract #53
Conversation
@mul1sh thanks for sharing! per the new file schema, best place for this file would probably be in /contracts/examples/Provider contracts |
@mikedeshazer done 🙂 |
@mul1sh biggest thing that sticks out is the voting period. As per issue this should be set in days so a user can easily set. The function we have now is fine however, could we add one function in which a user specifies a uint of the days from now to start and a period of days duration, as so its easy to calculate, and set by the owner? |
Done 🙂 |
@mul1sh will test over the weekend but will close the issue . Will merge by Monday once we can confirm all is well. Thanks! |
@mikedeshazer ok thanks |
Any feedback on this one yet @mikedeshazer |
Looks great! Looking forward to checking out the leveraged position contract as well! |
Fixes #52