Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the voting contract #53

Merged
merged 4 commits into from
Feb 10, 2020

Conversation

mul1sh
Copy link

@mul1sh mul1sh commented Feb 8, 2020

Fixes #52

@mikedeshazer
Copy link
Member

@mul1sh thanks for sharing! per the new file schema, best place for this file would probably be in /contracts/examples/Provider contracts

@mul1sh
Copy link
Author

mul1sh commented Feb 8, 2020

@mikedeshazer done 🙂

@mikedeshazer
Copy link
Member

@mul1sh biggest thing that sticks out is the voting period. As per issue this should be set in days so a user can easily set. The function we have now is fine however, could we add one function in which a user specifies a uint of the days from now to start and a period of days duration, as so its easy to calculate, and set by the owner?

@mul1sh
Copy link
Author

mul1sh commented Feb 8, 2020

Done 🙂

@mikedeshazer
Copy link
Member

@mul1sh will test over the weekend but will close the issue . Will merge by Monday once we can confirm all is well. Thanks!

@mul1sh
Copy link
Author

mul1sh commented Feb 8, 2020

@mikedeshazer ok thanks

@mul1sh
Copy link
Author

mul1sh commented Feb 10, 2020

Any feedback on this one yet @mikedeshazer

@mikedeshazer mikedeshazer merged commit 53faadf into ProofSuite:master Feb 10, 2020
@mikedeshazer
Copy link
Member

Looks great! Looking forward to checking out the leveraged position contract as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrFeed Judge Voting Contract For Prediction Market
2 participants