Feature/add thermo noise #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chambm
commented
Jun 21, 2021
| @@ -199,6 +199,9 @@ int main(int argc, char* argv[]) | |||
| config.peakPicking = true; | |||
| pwiz::util::testReader(reader, testArgs, testAcceptOnly, requireUnicodeSupport, IsRawFile(), config); | |||
|
|
|||
| config.addNoiseData = true; | |||
| pwiz::util::testReader(reader, testArgs, testAcceptOnly, requireUnicodeSupport, IsRawFile(), config); | |||
There was a problem hiding this comment.
Use IsNamedRawFile() to restrict the noise data test to 1 or 2 RAW files: we don't need tests for all the single scan RAW Files we have.
|
Hi @rfellers sorry it's taken so, so long to get back to this. I think the reason why I haven't merged this is all the extraneous whitespace changes that I haven't had time/motivation to clean up. Those extra changes make it hard to see what the commit(s) did when looking at the log. If you are still interested, please clean up those whitespace changes and the extra test issue, and I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @rfellers . I mostly just squashed his commits and added test data. Supersedes #165