Fix Pulse-Eight USB CEC adapter detection on macOS Mojave #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix! For others watching this repos: other PRs and issues are being taken care of, but I'm just merging a single PR atm to test a Jenkins config for building all of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In macOS Mojave the Pulse-Eight USB CEC adapter is presented as RS232 type instead of modem type as in previous macOS versions (see attached screenshot). This breaks adapter detection code in libcec. Changing the type to "kIOSerialBSDRS232Type" fixes the issue for macOS Mojave but probably breaks it on previous versions. Changing it to "kIOSerialBSDAllTypes" works on Mojave & should also work on previous versions of macOS.
This fixes #432