Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Players cannot drag/drop spells into items #24

Closed
DracLore1 opened this issue Nov 12, 2023 · 1 comment · Fixed by #26
Closed

[BUG] Players cannot drag/drop spells into items #24

DracLore1 opened this issue Nov 12, 2023 · 1 comment · Fixed by #26
Assignees
Labels
bug Something isn't working

Comments

@DracLore1
Copy link

Module Version: v1.3.2

Describe the bug
Players are unable to attach spells to items from the Compendiums or the Items section

To Reproduce
Steps to reproduce the behavior:

  1. Log in as player
  2. select/create an item and go to the Magic Item tab
  3. Click is magiv item
  4. Drag a spell into the "Drag spells/feats here' box
  5. Nothing happens

Expected behavior
The above should add the spell to the item

Screenshots
If applicable, add screenshots to help explain your problem.

Browser:
Tested in both - Firefox, Chrome

Foundry Version:
11 Stable 315

Additional context
Was working in Magic Items in v10, since updating to v11 and changing to magic items 2 it no longer works, I have checked all permissions for players and still nothing aside from being the GM works

@DracLore1 DracLore1 added the bug Something isn't working label Nov 12, 2023
@PwQt PwQt self-assigned this Nov 12, 2023
@PwQt
Copy link
Owner

PwQt commented Nov 12, 2023

Reproducable - i'll release the fix during this week, planning on making a bigger release.

Something must've changed inbetween v10 and v11 and this behaviour broke:

const dragDrop = new DragDrop({
        dropSelector: ".tab.magic-items",
        permissions: {
          dragstart: this.app._canDragStart.bind(this.app),
          drop: this.app._canDragDrop.bind(this.app),
        },
        callbacks: {
          dragstart: this.app._onDragStart.bind(this.app),
          dragover: this.app._onDragOver.bind(this.app),
          drop: this._onDrop.bind(this),
        },
        ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants