inconsistent results from isort when used in CI on travis

[samuelcolvin]

https://travis-ci.org/samuelcolvin/arq/builds/150409550

I'm trying to use isort in CI to make sure import orders are always correct, however I'm getting different results locally and on travis.

In /arq/testing.py isort on travis says there should be a blank link (see build report above), locally it says it's fine.

Both setups are running isort 4.2.5 with python 3.5.

The only difference I can find is that the local version of python is 3.5.0, while on travis it's 3.5.2.

[kaedroho]

Just been debugging this as I've hit this issue on a project I'm working on. It seems to be an issue with the way dependencies are installed. If dependencies are being installed with distutils (aka python setup.py install), some dependencies such as Pillow and BeautifulSoup get detected as "first party" by isort. This is probably because these dependencies use aliases (PIL = Pillow, bs4 = BeautifulSoup) which are handled differently by distutils so isort can't see them in your virtual environment and it assumes they're "first party".

A workaround is to run pip install -e. instead of python setup.py install. If you have caching enabled, don't forget to clear it!

[kaedroho]

@samuelcolvin The blank line you're getting indicates one of the imports are being detected as a different category to the other. Did you install all dependencies the same way locally as you did on TravisCI?

[kaedroho]

You can also workaround this by explicitly stating which dependencies are first/third party by using the known_first_party and known_third_party settings.

[timothycrosley]

@kaedroho's suggestions are on point, closing this issue for now, as I haven't been able to directly reproduce

Thanks!

~Timothy

[samuelcolvin]

Sorry not to close this issue sooner, pretty sure the problem was installing the library via pip install -e ... which made it appear "1st party", then installing it normally on travis.

[timothycrosley]

@samuelcolvin No worries! Glad your issue was resolved :)

[auvipy]

facing it on celery project as well. any suggestions?