Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id attribute not always available #54

Closed
wants to merge 1 commit into from
Closed

id attribute not always available #54

wants to merge 1 commit into from

Conversation

svenevs
Copy link

@svenevs svenevs commented May 5, 2018

Fixes #53.

I don't think "rage-replacing" xxx.id with getattr(xxx, "id", None) can be done / makes sense. Sometimes xxx.id is used as a key in a dictionary, etc. I only fixed the line that caused crashes for me.

Logically it should be equivalent though, and installing this locally pep8-naming no longer crashes :)

@svenevs
Copy link
Author

svenevs commented May 5, 2018

^ Sorry for force-push, I did "id" rather than 'id' and since the CI hadn't even finished I thought I'd fix it real quick before you even saw ;)

@svenevs
Copy link
Author

svenevs commented May 5, 2018

(to the watchers, sorry so much spam...CI ran on commit I force pushed away, which is why this will close and then repoen)

@svenevs svenevs closed this May 5, 2018
@svenevs svenevs reopened this May 5, 2018
@svenevs
Copy link
Author

svenevs commented May 5, 2018

Superseded by gh-55.

@svenevs svenevs closed this May 5, 2018
@svenevs svenevs deleted the fix/no-id-attribute branch May 5, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Attribute' object has no attribute 'id'
1 participant