Metaclass __new__ method should have mcs as first argument, not cls

[karyon]

in this class, pylint told me that the first argument to __new__ should be mcs, so i changed it. Afterwards, pycodestyle told me it should be cls, which i think is wrong.

[sigmavirus24]

I disagree. For reference, this section of PEP-0008 tells us that any class method should use cls to indicate that it's receiving a class object as a parameter. This section of PEP-0008 also says:

However, notwithstanding this rule, 'cls' is the preferred spelling for any variable or argument which is known to be a class, especially the first argument to a class method.

And the first argument to __new__ is known to be a class object. Thus, pycodestyle is correct. pylint is unlikely to change that requirement and as such, I'd suggest you silence one of the two tools.

[NeilGirdhar]

FYI: pylint-dev/pylint#2028