Skip to content

pointwise initial #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2020
Merged

pointwise initial #15

merged 3 commits into from
Mar 4, 2020

Conversation

Arkoniak
Copy link
Collaborator

@Arkoniak Arkoniak commented Mar 1, 2020

Most important changes

  1. Pointwise approach
  2. Result structure changed (borrowed from Clustering, since it's more controllable this way)
  3. pairwise! is no longer needed, changed it to colwise!
  4. updated tests
  5. Changed former divider utility function to a more stable version

Unfortunately, multithreading version is currently bugged, but it gives approximately correct results :-) So, one may test its performance in 100x100_000 scenario.

@Arkoniak Arkoniak requested a review from PyDataBlog March 1, 2020 07:11
@Arkoniak Arkoniak marked this pull request as ready for review March 4, 2020 07:44
@PyDataBlog PyDataBlog merged commit 8d1cbed into PyDataBlog:experimental Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyDataBlog PyDataBlog Awaiting requested review from PyDataBlog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkoniak @PyDataBlog