removed shivank folder, changes env to .env( as per Makefile), updated readme #33
Conversation
Review changes
|
Umm, don't know why this much commits are coming. I rebased the repo |
|
You probably rebased on top of your own master. You need to either rebase on top of pyj/master or sync your master to pyj/master and then rebase on origin/master. |
No I didn't deleted that. I changed to |
Ohh, ok |
| @@ -1,3 +0,0 @@ | |||
| export DATABASE_URL='postgres://postgres:password@localhost:5432' | |||
There was a problem hiding this comment.
Ok, I ll make changes. there is always mess when I do rebase :D
|
Also, our website works fine. do we even need this PR? I made this because I was facing some errors due to makefile not being able to identify |
|
Your synonyms might need to be re-setup. I fixed the theme.html thing on
master so that change is no longer needed.
…On Mon 4 May, 2020, 13:59 Shivank Gautam, ***@***.***> wrote:
Also, our website works fine. do we even need this PR? I made this because
I was facing some errors due to makefile not being able to identify .env.
but that might be due to my mistake in a symlink.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#33 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2WHUOFX6RHRHVNYA6WBMLRPZ4G5ANCNFSM4MYQ6NCQ>
.
|
|
*symlinks
…On Mon 4 May, 2020, 14:03 Arjoonn, ***@***.***> wrote:
Your synonyms might need to be re-setup. I fixed the theme.html thing on
master so that change is no longer needed.
On Mon 4 May, 2020, 13:59 Shivank Gautam, ***@***.***>
wrote:
> Also, our website works fine. do we even need this PR? I made this
> because I was facing some errors due to makefile not being able to identify
> .env. but that might be due to my mistake in a symlink.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#33 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB2WHUOFX6RHRHVNYA6WBMLRPZ4G5ANCNFSM4MYQ6NCQ>
> .
>
|
|
Right, closing this PR. |
No description provided.