Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of _hardthreshold_percentile seems incorrect in pylops/optimization/sparsity.py #249

Closed
shailesh1729 opened this issue Sep 18, 2021 · 1 comment

Comments

@shailesh1729
Copy link

In the file pylops/optimization/sparsity.py

_hardthreshold_percentile seems to call _halfthreshold internally, while it should be calling _hardthreshold.

  • _softthreshold_percentile correctly calls _softthreshold
  • _halfthreshold_percentile correctly calls _halfthreshold

It appears to be a typo in the definition of _hardthreshold_percentile .

I guess it's a typo.

@mrava87
Copy link
Collaborator

mrava87 commented Sep 18, 2021

Hi @shailesh1729,
you are totally right. I am going to change this and it would take place immediately in master and soon in stable as soon as we release v1.15.0 :)

Thanks!

mrava87 added a commit that referenced this issue Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants