-
Notifications
You must be signed in to change notification settings - Fork 444
Dstara/fix mysql.c includes #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
DimitrisStaratzis
wants to merge
36
commits into
PyMySQL:main
from
TileDB-Inc:dstara/fix_mysql.c_includes
Closed
Dstara/fix mysql.c includes #712
DimitrisStaratzis
wants to merge
36
commits into
PyMySQL:main
from
TileDB-Inc:dstara/fix_mysql.c_includes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errmsg.sys is needed by embedded mariadb for the language errors
MariaDB archives don't always keep all old versions, we were getting false failures to do cdns missing 10.4.8
…edb-2.2 Update dockerfile to TileDB 2.2 and MyTile 0.7
…ry-init remove mysql library init call
The MariaDB embedded server can only be started once per process. You can open as many connections as you want, but the starting of the server can only happen once. Currently the start is protected fine, but on connection close the server was shutdown. This meant that open and closing connections was causing segfaults because MariaDB can't be started again once it is stopped in embedded mode. The change here makes the stopping of the server happen as global process level when the python module is unloaded.
…own-server-on-module-exit Use atexit to only shutdown MariaDB on module exit
Update docker image for TileDB 2.6.2 and MyTile 0.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should be part of a new release that will be used in libtiledb-sql-py to fix the
missing symbol error
in macOS-arm64. It has been tested on all platforms.