Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Do not build wheels for python versions not supported by package #195

Closed
clbarnes opened this issue Aug 30, 2019 · 3 comments · Fixed by #495
Closed

Feature request: Do not build wheels for python versions not supported by package #195

clbarnes opened this issue Aug 30, 2019 · 3 comments · Fixed by #495
Labels
enhancement New feature or request

Comments

@clbarnes
Copy link
Contributor

clbarnes commented Aug 30, 2019

My computer has more versions of python installed on it than my pyo3-based library supports. maturin build should not build wheels for unsupported python versions. Of course, it's possible to specify exactly which versions to build on every call to maturin build, but that's a relatively static item of metadata which is a good fit for a config file (probably the Cargo.toml, although possibly pyproject.toml).

One option would be to parse the trove classifiers specified in package.metadata.maturin.classifier package.metadata.maturin.requires-python, and build wheels for the intersection of what maturin supports and what is specified there.

@konstin
Copy link
Member

konstin commented Aug 30, 2019

What operating system are you using and what are those python versions? For unix system, maturin has a predefined list it checks, and for windows, it's using py -0 and picks only python3 versions.

@clbarnes
Copy link
Contributor Author

Using ubuntu, I have pythons 2.7, 3.4, 3.5, 3.6, and 3.7. My package only supports 3.6 and 3.7. Maturin ignores 2.7 and 3.4, as it should, but still creates a wheel for 3.5.

@konstin
Copy link
Member

konstin commented Aug 30, 2019

Thanks for the clarification, I see now. It should definitely be supported to restrict the python through some metadata key.

@konstin konstin added the enhancement New feature or request label Aug 30, 2019
@clbarnes clbarnes changed the title Feature request: Do not build wheels for unsupported python versions Feature request: Do not build wheels for python versions not supported by package Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants