macros: clean up protocol argument extraction a bit #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Oct 31, 2021
Comment on lines
456
to
459
| const __IADD__: SlotDef = SlotDef::new("Py_nb_inplace_add", "binaryfunc") | ||
| .arguments(&[Ty::ObjectOrNotImplemented]) | ||
| .arguments(&[Ty::Object]) | ||
| .extract_error_mode(ExtractErrorMode::NotImplemented) | ||
| .return_self(); |
There was a problem hiding this comment.
@birkenfeld: in answer to #1945 (comment)
These definitions state what the generated function signature will be and place constraints on what is allowed in the pymethod. For example this __iadd__ definition will require there to be only one argument, of any type, and the return type to be () or PyResult<()> (because the macro-generated code will return self).
If the user deviates from these constraints there should be a compile error, however the error messages can probably be improved.
davidhewitt
force-pushed
the
pymethods-protos-arguments-cleanup
branch
from
a4cb2ff
to
6a3e1e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just tidies up the code which does argument extraction for protocol
#[pymethods]a little.