Protocols: implement __getattribute__ #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
commented
Feb 25, 2022
src/impl_/pyclass.rs
Outdated
| attr: *mut ffi::PyObject, | ||
| ) -> PyResult<*mut ffi::PyObject> { | ||
| let res = ffi::PyObject_GenericGetAttr(slf, attr); | ||
| if res.is_null() { Err(PyErr::fetch(py)) } |
There was a problem hiding this comment.
I'm not sure about this implementation, does it look correct?
src/impl_/pyclass.rs
Outdated
| _slf: *mut ffi::PyObject, | ||
| attr: *mut ffi::PyObject, | ||
| ) -> PyResult<*mut ffi::PyObject> { | ||
| Err(PyErr::new::<PyAttributeError, _>((Py::<PyAny>::from_owned_ptr(py, attr),))) |
There was a problem hiding this comment.
I think this pointer is not owned by the function call, so need to use from_borrowed:
Suggested change
| Err(PyErr::new::<PyAttributeError, _>((Py::<PyAny>::from_owned_ptr(py, attr),))) | |
| Err(PyErr::new::<PyAttributeError, _>((Py::<PyAny>::from_borrowed_ptr(py, attr),))) |
davidhewitt
reviewed
Feb 26, 2022
src/impl_/pyclass.rs
Outdated
| _slf: *mut ffi::PyObject, | ||
| attr: *mut ffi::PyObject, | ||
| ) -> PyResult<*mut ffi::PyObject> { | ||
| Err(PyErr::new::<PyAttributeError, _>((Py::<PyAny>::from_owned_ptr(py, attr),))) |
There was a problem hiding this comment.
I think this pointer is not owned by the function call, so need to use from_borrowed:
Suggested change
| Err(PyErr::new::<PyAttributeError, _>((Py::<PyAny>::from_owned_ptr(py, attr),))) | |
| Err(PyErr::new::<PyAttributeError, _>((Py::<PyAny>::from_borrowed_ptr(py, attr),))) |
src/impl_/pyclass.rs
Outdated
| attr: *mut ffi::PyObject, | ||
| ) -> PyResult<*mut ffi::PyObject> { | ||
| let res = ffi::PyObject_GenericGetAttr(slf, attr); | ||
| if res.is_null() { Err(PyErr::fetch(py)) } |
Merged
converting tp_getattro to a shared slot Fixes #2186
birkenfeld
force-pushed
the
getattribute
branch
from
d8153cf
to
dc4f114
Compare
|
Thanks for the review, should be good now. |
davidhewitt
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converting tp_getattro to a shared slot
Fixes #2186