Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-MIT contributions #3387

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Aug 15, 2023

As per #2339 (comment)

This PR reverts commits by @cecini, @potocpav, and @thanatos, who have been the non-respondents to our intent to relicense.

Mostly these lines have been reworked or replaced already, so the majority of these reverts are empty and purely present for ceremonial purpose.

The one possible change which was meaningful was correct handling of Py_TRACE_REFS flag which was part of Py_DEBUG up to and including 3.7. Therefore to move forward I propose to drop support for debug builds on Python 3.7. @alex I assume that dropping support of 3.7 debug interpreters will not impact cryptography, given debug wheels aren't shipped to PyPI.

@DataTriny
Copy link
Contributor

I just double-checked we weren't missing anyone. Every boxes are now ticked except for the people mentioned here!

@alex
Copy link
Contributor

alex commented Aug 15, 2023

Yeah, I'm not sure I've ever done anything with a debug interpreter + pyo3, so no impact for us.

@davidhewitt davidhewitt added this pull request to the merge queue Aug 15, 2023
Merged via the queue into PyO3:main with commit 1a64eb0 Aug 15, 2023
31 checks passed
@davidhewitt davidhewitt deleted the remove-non-mit-contributions branch August 15, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants