replace DowncastError with CastError
#5468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5468 will degrade performances by 10.16%Comparing Summary
Benchmarks breakdown
|
Icxolu
reviewed
Sep 27, 2025
| /// Like `downcast_exact` but takes ownership of `self`. | ||
| // FIXME(icxolu) deprecate in favor of `Bound::cast_into_exact` | ||
| fn downcast_into_exact<T>(self) -> Result<Bound<'py, T>, DowncastIntoError<'py>> | ||
| fn downcast_into_exact<T>(self) -> Result<Bound<'py, T>, CastIntoError<'py>> |
There was a problem hiding this comment.
I wonder whether we should just deprecate these as well now, and keep the old error type.
There was a problem hiding this comment.
I think that's a really good idea, let me send a PR to deprecate those separately, I'll revert the error type here for now.
There was a problem hiding this comment.
Proabably need #5472 to merge first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5393
This PR adds
CastErroras a new error type, leavingDowncastErroras-is but deprecated.Across the codebase I swap all
DowncastErrorforCastError, and same forDowncastIntoError->CastIntoError.