guide: fixes and some minor additions #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went through the guide and fixed some grammar/consistency issues, and added some wording where I thought it appropriate. I also reordered the chapters to what I feel is a more natural flow of concepts.
davidhewitt
approved these changes
Mar 12, 2020
Comment on lines
+34
to
36
| ## `*args` and `**kwargs` for Python object calls | ||
|
|
||
| There are several ways how to pass positional and keyword arguments to a Python object call. |
There was a problem hiding this comment.
Should we maybe call these "Python function calls" instead of "Python object calls"?
There was a problem hiding this comment.
For me both are fine; there isn't a big distinction between calling functions and calling other callables, such as classes to create an instance.
kngwyu
approved these changes
Mar 13, 2020
|
Awesome, thank you for so many improvements! Looks the test failure is caused by missing |
Co-Authored-By: Yuji Kanagawa <yuji.kngw.80s.revive@gmail.com> Co-Authored-By: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the guide and fixed grammar/consistency/indentation issues,
and added some wording where I thought it appropriate.
I also reordered the chapters to what I feel is a more natural
flow of concepts.