Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.9.0 #812

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Bump version to 0.9.0 #812

merged 3 commits into from
Mar 19, 2020

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Mar 17, 2020

Resolves #808

@birkenfeld
Copy link
Member

@kngwyu I'd like to update the docstrings of pyo3 types to point to the new guide first. I can do it today.

@kngwyu
Copy link
Member Author

kngwyu commented Mar 17, 2020

@birkenfeld
Thank you!
I'm willing to wait for that.

@birkenfeld
Copy link
Member

Can we also import PyAny to the main crate namespace?

@kngwyu
Copy link
Member Author

kngwyu commented Mar 17, 2020

@birkenfeld
I don't have any strong opinions about that.
They are hidden since 302c099 and left as is.
@konstin
What kind of intention did you have for not exposing types::* in lib.rs?

@birkenfeld
Copy link
Member

I think it makes sense to put the long list of concrete types there.

But if we want to enhance visibility of PyAny and make clear that it's an important type, counterpart to PyObject, it should be in the root/prelude.

@konstin
Copy link
Member

konstin commented Mar 17, 2020

The idea was to prevent the top level from becoming to cluttered with all the builtin types. But imo PyAny can also be the root namespace and/or the prelude.

@kngwyu
Copy link
Member Author

kngwyu commented Mar 17, 2020

@birkenfeld @konstin
Thank you for the feedback!
I'll create a PR for PyAny later.

@kngwyu kngwyu force-pushed the release-0.9 branch 2 times, most recently from 5d581b1 to 1f8a975 Compare March 18, 2020 15:29
@kngwyu
Copy link
Member Author

kngwyu commented Mar 19, 2020

Now ready to release :)

@kngwyu kngwyu merged commit d43a349 into master Mar 19, 2020
@birkenfeld
Copy link
Member

Thanks! Can you set a tag?

@kngwyu
Copy link
Member Author

kngwyu commented Mar 19, 2020

Sure, I made it now. https://github.com/PyO3/pyo3/releases/tag/v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release non-alpha version of 0.9
3 participants