More ergonomic error messages for invalid #[pyclass] args #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
reviewed
Mar 22, 2020
kngwyu
force-pushed
the
pyclass-err-improve
branch
from
5787128
to
ec2b66f
Compare
davidhewitt
reviewed
Mar 22, 2020
pyo3-derive-backend/src/pyclass.rs
Outdated
| return Err(syn::Error::new_spanned( | ||
| exp.path.clone(), | ||
| "Unsupported parameter", | ||
| )); | ||
| format!("Expected one of gc/weakref/subclass/dict, but got {}", x), |
There was a problem hiding this comment.
Could perhaps add a test for this case too?
tests/ui/invalid_pyclass_args.stderr
Outdated
Comment on lines
13
to
17
| error: Expected type name (e.g., Name), but got m :: MyClass | ||
| --> $DIR/invalid_pyclass_args.rs:9:18 | ||
| | | ||
| 9 | #[pyclass(name = m::MyClass)] | ||
| | ^^^^^^^^^^ |
There was a problem hiding this comment.
I'm trying to decide if the but got x portion of the error messages is necessary.
On the plus side, they make the error description slightly nicer to read.
However, the invalid "but got" input is already highlighted in the source code beneath the error, so we're kinda repeating the information twice.
Also, in this m::MyClass case the formatting has been changed versus the original source code, which makes it a bit weird to read.
There was a problem hiding this comment.
cc @gilescope who reported the original issue.
There was a problem hiding this comment.
Thank you, I chose a simplfied one.
Co-Authored-By: Georg Brandl <georg@python.org>
kngwyu
force-pushed
the
pyclass-err-improve
branch
from
ec2b66f
to
3b17ab0
Compare
davidhewitt
approved these changes
Mar 23, 2020
|
Cracking. Sent with GitHawk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #823