Skip to content

Disable Vec<*mut ffi::PyObject> <-> numpy.ndarray conversion #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2019
Merged

Disable Vec<*mut ffi::PyObject> <-> numpy.ndarray conversion #116

merged 6 commits into from
Nov 3, 2019

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Nov 2, 2019 •
edited
Loading

There are some problems with reference counting and ... now I have no idea to fix it.
Maybe to_pyarray can be safe but anyway TypeNum is not appropriate for PyObject.

Resolves #113.

@kngwyu kngwyu force-pushed the vec_obj branch 2 times, most recently from 963f826 to e64a91e Compare November 2, 2019 14:43
@kngwyu kngwyu force-pushed the vec_obj branch 5 times, most recently from 8cbf602 to e2bb1d5 Compare November 3, 2019 07:44
@kngwyu kngwyu merged commit 6aad7ae into PyO3:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure in into_obj_vec_to_pyarray with ndarray 0.13
1 participant
@kngwyu